I have managed to collect quite a few of these glasses, which date from the 1920s to the 1960s. They cover teams from all over Scotland and came in different styles and sizes, with the last three being tankards with the players' signatures printed. The tankards are more robust and have survived in reasonable numbers, but the early glass ones are fragile and rare.
Here are photos of the ones in my collection although I know there are more examples out there, for example the earliest I have seen was for Morton in 1921. And there is even one, pictured at the end, for Troon Athletic who won the Ayrshire Junior Cup in 1922.
The only clue to who made them is on the 1928 glass when Rangers won the league and cup double. It has Crocket & Son of Buchanan Street printed below the graphics, but whether they made them or just sold them is hard to say. That year is also different as there is Scottish League flag printed on the back.
Needless to say, I would be interested to know of any further examples.